Re: [PATCH 1/2] ref-filter: mark a file-local symbol as static
- Date: Thu, 1 Mar 2018 19:59:04 -0800
- From: Jonathan Nieder <jrnieder@xxxxxxxxx>
- Subject: Re: [PATCH 1/2] ref-filter: mark a file-local symbol as static
Ramsay Jones wrote:
> Commit fcfba37337 ('ref-filter: make "--contains <id>" less chatty if
> <id> is invalid', 2018-02-23) added the add_str_to_commit_list()
> function, which causes sparse to issue a "... not declared. Should it
> be static?" warning for that symbol.
Thanks for catching it!
> In order to suppress the warning, mark that function as static.
Isn't this closer to
Indeed, the function is only used in this one compilation
unit. Mark it static.
? In other words, sparse's warning is accurate, and this is not about
trying to quiet a false positive but about addressing a true positive.
> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx>
> ref-filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)