Web lists-archives.com

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep




Junio C Hamano <gitster@xxxxxxxxx> writes:

>> -	test_i18ngrep -E '^(fatal|warning):' <error | grep -v 'hung up' >actual | sort &&
>> +	grep -E '^(fatal|warning):' <error | grep -v 'hung up' >actual &&
>>  	test_i18ncmp expected actual
>
> OK, but not quite OK.
>
> Two grep invocations will not leave anything useful in 'actual'
> under poison build, and is almost guaranteed that 'expected' would
> not match, but that is perfectly OK because the final comparison is
> done.

Sorry.  s/is done./is done with i18ncmp./ is what I wanted to say.