Re: [RFC PATCH 000/194] Moving global state into the repository object
- Date: Thu, 8 Feb 2018 07:42:53 -0800
- From: Elijah Newren <newren@xxxxxxxxx>
- Subject: Re: [RFC PATCH 000/194] Moving global state into the repository object
On Mon, Feb 5, 2018 at 3:51 PM, Stefan Beller <sbeller@xxxxxxxxxx> wrote:
> This series moves a lot of global state into the repository struct.
> It applies on top of 2512f15446149235156528dafbe75930c712b29e (2.16.0)
> It can be found at https://github.com/stefanbeller/git/tree/object-store
> Motivation for this series:
> * Easier to reason about code when all state is stored in one place,
> for example for multithreading
> * Easier to move to processing submodules in-process instead of
> calling a processes for the submodule handling.
> The last patch demonstrates this.
For what it's worth...I spot checked some random patches, looked
closely at the changes to merge-recursive, and looked at what was
happening to cache.h
I like how you structured the series, and I like the goals. Didn't
find any problems in the small pieces I looked at.