Web lists-archives.com

Re: [PATCH] t0050: remove the unused $test_case variable




Am 07.02.2018 um 00:13 schrieb Ævar Arnfjörð Bjarmason:
The $test_case variable hasn't been used since
decd3c0c28 ("t0050-*.sh: mark the rename (case change) test as
passing", 2014-11-28) when its last user went away.

Let's remove the "say" as well, since it's obvious from subsequent
output that we're testing on a case sensitive filesystem.

Am I misunderstanding the message? I think it reports properties of the test environment. And the tests do run on case-insensitive filesystems. IMO, the message should be kept.


Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
---
  t/t0050-filesystem.sh | 8 --------
  1 file changed, 8 deletions(-)

diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh
index b29d749bb7..606ffddd92 100755
--- a/t/t0050-filesystem.sh
+++ b/t/t0050-filesystem.sh
@@ -7,14 +7,6 @@ test_description='Various filesystem issues'
  auml=$(printf '\303\244')
  aumlcdiar=$(printf '\141\314\210')
-if test_have_prereq CASE_INSENSITIVE_FS
-then
-	say "will test on a case insensitive filesystem"
-	test_case=test_expect_failure
-else
-	test_case=test_expect_success
-fi
-
  if test_have_prereq UTF8_NFD_TO_NFC
  then
  	say "will test on a unicode corrupting filesystem"