Web lists-archives.com

Re: [PATCH 0/2] Refactor hash search with fanout table




On 2/2/2018 6:30 PM, Junio C Hamano wrote:
Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes:

After reviewing Derrick's Serialized Git Commit Graph patches [1], I
noticed that "[PATCH v2 11/14] commit: integrate commit graph with
commit parsing" contains (in bsearch_graph) a repeat of some packfile
functionality. Here is a pack that refactors that functionality out.

Yay.  I had exactly the same reaction to that part of the series.


Thanks for doing this refactor. I'm a fan of reducing code clones, but also don't want to break well-worn code paths.

Jonathan: While you are doing this, I'm guessing you could use your new method to replace (and maybe speed up) the binary search in sha1_name.c:find_abbrev_len_for_pack(). Otherwise, I can take a stab at it next week.

Please add
Reviewed-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx>

Thanks,
-Stolee