Web lists-archives.com

Re: [PATCH 01/40] Add initial external odb support




On Thu, Jan 4, 2018 at 8:59 PM, Jeff Hostetler <git@xxxxxxxxxxxxxxxxx> wrote:
>
>> diff --git a/odb-helper.h b/odb-helper.h
>> new file mode 100644
>> index 0000000000..9395e606ce
>> --- /dev/null
>> +++ b/odb-helper.h
>> @@ -0,0 +1,24 @@
>> +#ifndef ODB_HELPER_H
>> +#define ODB_HELPER_H
>> +
>> +struct odb_helper {
>> +       const char *name;
>> +       const char *dealer;
>> +
>> +       struct odb_helper_object {
>> +               unsigned char sha1[20];
>
>
> Should this be "struct object_id" ?

Yeah, I changed this in my current version.

I cannot change all the functions to take a struct object_id though as
some are called inside sha1_file.c where there are only sha1.