Re: [PATCH v2 0/2] Incremental rewrite of git-submodules
- Date: Thu, 11 Jan 2018 12:37:05 -0800
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH v2 0/2] Incremental rewrite of git-submodules
Prathamesh Chavan <pc44800@xxxxxxxxx> writes:
> Changes made to the previous version of the patch series:
> * Since later on with certain patches, the number of bit-parameters to
> be passed to a few functions depend on many parameters, I prefered
> using a single flag bit.
I am not quite getting what you meant to say here.
> * Memory-leak of the variable 'remote' in the function:
> print_default_remote() was avoided.
avoided how? I am not quite getting what you meant to say here.
> * Additional condition were introduced while freeing the variables:
> sub_origin_url and super_config_url.
As I said, I do not think the change goes into the right direction.