Re: [PATCH] run-command.c: print env vars when GIT_TRACE is set
- Date: Wed, 10 Jan 2018 11:35:18 -0800
- From: Stefan Beller <sbeller@xxxxxxxxxx>
- Subject: Re: [PATCH] run-command.c: print env vars when GIT_TRACE is set
On Wed, Jan 10, 2018 at 11:26 AM, Brandon Williams <bmwill@xxxxxxxxxx> wrote:
> On 01/10, Stefan Beller wrote:
>> On Wed, Jan 10, 2018 at 10:09 AM, Brandon Williams <bmwill@xxxxxxxxxx> wrote:
>> > At first when i read this I was under the impression that the whole
>> > environment was going to be printed out...but i now realize that this
>> > tracing will only print out the delta's or the additions to the
>> > environment that the child will see. Maybe this should be called out
>> > more clearly in the commit message?
>> It only adds newly set variables, I wonder why deletions are noisy?
>> I could not find an example of a removal of environment variables
>> specific to submodules that would be noisy.
> Deletions are noisy because we append local_repo_env anytime we kick
> off a child process (ok maybe not all the time, but a lot of the time)
> which is just a list of ~15 deletions.
Oh, I see. I'm fine with that.
Though to further the discussion, maybe we want to check if such a variable
is set and if so actually show the deletion? I have the impression that most
of the variables are not set, and yet we unconditionally delete them, "just to
be sure". Maybe we'd only want to delete them if we actually have them
set in the superproject, and then we can show the diff in env vars