[PATCH v2 12/18] ref-filter: make populate_value global
- Date: Wed, 10 Jan 2018 09:36:41 +0000
- From: Olga Telezhnaya <olyatelezhnaya@xxxxxxxxx>
- Subject: [PATCH v2 12/18] ref-filter: make populate_value global
Make function global for further using in cat-file.
Also added return value for handling errors.
Signed-off-by: Olga Telezhnaia <olyatelezhnaya@xxxxxxxxx>
Mentored-by: Christian Couder <christian.couder@xxxxxxxxx>
Mentored by: Jeff King <peff@xxxxxxxx>
---
ref-filter.c | 4 ++--
ref-filter.h | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 575c5351d0f79..c15906cb091c7 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1454,7 +1454,7 @@ static void need_object(struct ref_array_item *ref) {
/*
* Parse the object referred by ref, and grab needed value.
*/
-static void populate_value(struct ref_array_item *ref)
+int populate_value(struct ref_array_item *ref)
{
int i;
@@ -1575,7 +1575,7 @@ static void populate_value(struct ref_array_item *ref)
break;
}
}
- return;
+ return 0;
}
/*
diff --git a/ref-filter.h b/ref-filter.h
index 9bd36243481b4..6df45c5bd9dcb 100644
--- a/ref-filter.h
+++ b/ref-filter.h
@@ -176,4 +176,7 @@ void setup_ref_filter_porcelain_msg(void);
void pretty_print_ref(const char *name, const unsigned char *sha1,
const struct ref_format *format);
+/* Fill the values of request and prepare all data for final string creation */
+int populate_value(struct ref_array_item *ref);
+
#endif /* REF_FILTER_H */
--
https://github.com/git/git/pull/450