Web lists-archives.com

[PATCH v3 3/3] send-email: add test for Linux's get_maintainer.pl

From: Alex Bennée <alex.bennee@xxxxxxxxxx>

We had a regression that broke Linux's get_maintainer.pl. Using
Mail::Address to parse email addresses fixed it, but let's protect
against future regressions.

Note that we need --cc-cmd to be relative because this option doesn't
accept spaces in script names (probably to allow --cc-cmd="executable
--option"), while --smtp-server needs to be absolute.

Patch-edited-by: Matthieu Moy <git@xxxxxxxxxxxxxxx>
Signed-off-by: Alex Bennée <alex.bennee@xxxxxxxxxx>
Signed-off-by: Matthieu Moy <git@xxxxxxxxxxxxxxx>
Change since v2:

* Mention relative Vs absolute path in commit message.

* Remove useless "chmod +x"

* Remove useless double quotes

 t/t9001-send-email.sh | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 4d261c2..a06e5d7 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -172,6 +172,25 @@ test_expect_success $PREREQ 'cc trailer with various syntax' '
 	test_cmp expected-cc commandline1
+test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer' "
+	write_script expected-cc-script.sh <<-EOF
+	echo 'One Person <one@xxxxxxxxxxx> (supporter:THIS (FOO/bar))'
+	echo 'Two Person <two@xxxxxxxxxxx> (maintainer:THIS THING)'
+	echo 'Third List <three@xxxxxxxxxxx> (moderated list:THIS THING (FOO/bar))'
+	echo '<four@xxxxxxxxxxx> (moderated list:FOR THING)'
+	echo 'five@xxxxxxxxxxx (open list:FOR THING (FOO/bar))'
+	echo 'six@xxxxxxxxxxx (open list)'
+test_expect_success $PREREQ 'cc trailer with get_maintainer.pl output' '
+	clean_fake_sendmail &&
+	git send-email -1 --to=recipient@xxxxxxxxxxx \
+		--cc-cmd=./expected-cc-script.sh \
+		--smtp-server="$(pwd)/fake.sendmail" &&
+	test_cmp expected-cc commandline1
 test_expect_success $PREREQ 'setup expect' "
 cat >expected-show-all-headers <<\EOF