Re: [PATCH 0/2] Several fixes for the test suite related to spaces in filenames
- Date: Wed, 03 Jan 2018 16:22:39 -0800
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH 0/2] Several fixes for the test suite related to spaces in filenames
Jeff King <peff@xxxxxxxx> writes:
> On Wed, Jan 03, 2018 at 05:54:44PM +0100, Johannes Schindelin wrote:
>> The second issue was found long ago, and the patch carried in Git for
>> Windows, although nothing about it is specific to Windows.
>> The first patch was developed today, when I tried to verify that Git's
>> test suite passes if Git is cloned to a directory called `with spaces/`.
> Heh, the whole point of the space in the trash directory was to find
> these issues early, but obviously it is not foolproof. :)
> The patches themselves look good to me from inspection. Thanks.
Yes, these changes look good. Thanks both.