Web lists-archives.com

Re: [PATCH v6 09/12] fixup: sha1_file: convert gotos to break/continue






On 12/5/2017 3:54 PM, Junio C Hamano wrote:
Jeff Hostetler <git@xxxxxxxxxxxxxxxxx> writes:

From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>

Signed-off-by: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>
---
  sha1_file.c | 40 ++++++++++++++++++++--------------------
  1 file changed, 20 insertions(+), 20 deletions(-)

The second (i.e. this) part and the third part are not yet in
'next', so it will perfectly be fine to squash these into the
commits that introduces the issues that are corrected in this
"fixup".  The same comment applies to all the other "fixup" patches.


OK thanks.  I left this one as a separate commit so that
we could debate the merits of the while(1) vs the gotos
and keep/reject independent of the other changes.  I'll
squash it in the next version.

Thanks
Jeff