Re: [PATCH 2/2] progress: drop delay-threshold code
- Date: Tue, 5 Dec 2017 13:28:21 +0100
- From: Lars Schneider <larsxschneider@xxxxxxxxx>
- Subject: Re: [PATCH 2/2] progress: drop delay-threshold code
> On 05 Dec 2017, at 12:10, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote:
> On Tue, Dec 5, 2017 at 11:37 AM, Lars Schneider
> <larsxschneider@xxxxxxxxx> wrote:
>>> On 04 Dec 2017, at 23:07, Jeff King <peff@xxxxxxxx> wrote:
>>> From: Lars Schneider <larsxschneider@xxxxxxxxx>
>>> Since 180a9f2268 (provide a facility for "delayed" progress
>>> reporting, 2007-04-20), the progress code has allowed
>>> callers to skip showing progress if they have reached a
>>> percentage-threshold of the total work before the delay
>>> period passes.
>>> But since 8aade107dd (progress: simplify "delayed" progress
>>> API, 2017-08-19), that parameter is not available to outside
>>> callers (we always passed zero after that commit, though
>>> that was corrected in the previous commit to "100%").
>>> Let's drop the threshold code, which never triggers in
>>> any meaningful way.
>>> Signed-off-by: Jeff King <peff@xxxxxxxx>
>>> I tweaked your patch slightly to clean up the now-simplified
>> Your first patch ("progress: set default delay threshold to 100%, not 0%")
>> as well as the modifications to this one look good to me. Feel free
>> to add my "Signed-off-by: Lars Schneider <larsxschneider@xxxxxxxxx>".
>> PS: How do you generate the commit references "hash (first line, date)"?
>> Git log pretty print?
> $ git grep -A5 'Copy commit summary' Documentation/SubmittingPatches
> Documentation/SubmittingPatches:151:The "Copy commit summary" command
> of gitk can be used to obtain this
> Documentation/SubmittingPatches-152-format, or this invocation of `git show`:
> Documentation/SubmittingPatches-155- git show -s --date=short
> --pretty='format:%h ("%s", %ad)' <commit>