Re: [PATCH 4/4] sha1dc: remove in favor of using sha1collisiondetection as a submodule
- Date: Tue, 5 Dec 2017 02:10:10 -0500
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 4/4] sha1dc: remove in favor of using sha1collisiondetection as a submodule
On Tue, Nov 28, 2017 at 09:32:14PM +0000, Ævar Arnfjörð Bjarmason wrote:
> As an aside: Now where was that .gitdiffsort or whatever it was called
> which would enable us to show sha1dc_git.h before nuking the contents
> of sha1dc? :)
diff.orderFile, I think.
> It also occurs to me that it would be useful for patch formatting in
> general to make all file removals go after file changes & additions.
I wonder if that might run afoul of programs which try to apply patches
in order. I think "git apply" is smart enough to apply all deletions
(regardless of order) before any creations (so it cannot be fooled by
adding "foo" followed by deleting "foo/bar"). So maybe it's fine.