Re: [PATCH] hashmap: adjust documentation to reflect reality
- Date: Wed, 29 Nov 2017 16:16:12 -0800
- From: Jonathan Nieder <jrnieder@xxxxxxxxx>
- Subject: Re: [PATCH] hashmap: adjust documentation to reflect reality
Johannes Schindelin wrote:
> The hashmap API is just complicated enough that even at least one
> long-time Git contributor has to look up how to use it every time he
> finds a new use case. When that happens, it is really useful if the
> provided example code is correct...
> While at it, "fix a memory leak", avoid statements before variable
> declarations, fix a const -> no-const cast, several %l specifiers (which
> want to be %ld), avoid using an undefined constant, call scanf()
> correctly, use FLEX_ALLOC_STR() where appropriate, and adjust the style
> here and there.
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
> hashmap.h | 60 +++++++++++++++++++++++++++++-------------------------------
> 1 file changed, 29 insertions(+), 31 deletions(-)
Yay, thanks for this.
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
Follow-on idea for the interested: would making a test that extracts
this sample code from hashmap.h and confirms it still works be a crazy