Web lists-archives.com

Re: [PATCH v4 0/2] launch_editor(): indicate that Git waits for user input




On Wed, Nov 29, 2017 at 03:37:50PM +0100, lars.schneider@xxxxxxxxxxxx wrote:
> +		if (print_waiting_for_editor) {
> +			fprintf(stderr, _("hint: Waiting for your editor input..."));
>  			fflush(stderr);

Just FYI, stderr is typically unbuffered on most systems I've used, and
although the call to fflush() is harmless, I suspect it's not having any
effect.  That said, there's plenty of other places in Git which seems to think
fflush()ing stderr actually does something.

-- Thomas Adam