Re: [PATCH v3 4/4] exec_cmd: RUNTIME_PREFIX on some POSIX systems
- Date: Tue, 28 Nov 2017 15:08:53 +0100 (CET)
- From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
- Subject: Re: [PATCH v3 4/4] exec_cmd: RUNTIME_PREFIX on some POSIX systems
Hi Dan, and (based on the timezone recorded in your mail:) good morning!
On Mon, 27 Nov 2017, Dan Jacques wrote:
> > In Git for Windows, we have an almost identical patch:
> > https://github.com/git-for-windows/git/commit/bdd739bb2b0b
> > We just guard the call to system_path() behind a test whether podir is
> > already absolute, but these days, system_path() does that itself.
> > I am too little of a Perl expert to be helpful with the other patches, but
> > I would gladly runa build & test on Windows if you direct me to an
> > easily-pullable branch.
> Oh interesting - I've only peripherally looked at Git-for-Windows code,
> since Chromium uses its packages verbatim (thanks, BTW!). I think you're
> correct though - this patch set seems to be doing the same thing.
Excellent, thanks for confirming.
> I've been force-pushing my changes to the "runtime-prefix" branch of my
> Git fork for travis.ci testing. The latest commit on that branch adds a
> "config.mak" for testing, so one commit from the branch head will
> contain the sum set of this patch series applied at (or near) Git's
> master branch:
> Let me know if this is what you are looking for, and if I can offer any
> help with Windows testing. Thanks!
Thank you, that was exactly what I was looking for.
BTW I think that your config.mak settings are partially unnecessary: the
gitexecdir and template_dir should be identical, and sysconfdir, too (at
least unless you override prefix).
I triggered a build (with the config.mak commit, because it does not
really matter), and it failed immediately due to a quoting issue: the path
separator is a semicolon on Windows and therefore must be quoted (so that
it is not misinterpreted as ending the command). There were a couple of
other issues, too, and I opened a PR here: