Re: [PATCH 3/5] rebase -i: add exec commands via the rebase--helper
- Date: Tue, 28 Nov 2017 08:48:33 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH 3/5] rebase -i: add exec commands via the rebase--helper
Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> could I ask for a favor? I'd like the oneline to start with
> rebase -i -x: ...
> (this would help future me to realize what this commit touches already
> from the concise graph output I favor).
>> Recent work on `git-rebase--interactive` aim to convert shell code to C.
>> Even if this is most likely not a big performance enhacement, let's
>> convert it too since a comming change to abbreviate command names requires
>> it to be updated.
> Since Junio did not comment on the commit message: could you replace
> `aim` by `aims`, `enhacement` by `enhancement` and `comming` by `coming`?
Yes, I noticed them but don't mind me ;-) The above are all good fixes.
All suggestions in the remainder looked sensible. Thanks for a