Re: [PATCH v3] launch_editor(): indicate that Git waits for user input
- Date: Mon, 27 Nov 2017 18:05:20 -0500
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH v3] launch_editor(): indicate that Git waits for user input
On Mon, Nov 27, 2017 at 08:09:32PM +0000, brian m. carlson wrote:
> > Show a message in the original terminal and get rid of it when the
> > editor returns.
> Sorry for coming to the topic so late, but it occurred to me that we
> might want to conditionalize this on an advice.* flag. I expect there
> are some people who will never want to see this, and letting them turn
> it off would be good.
I am torn between saying "yes please, I would absolutely set such an
option myself" and "if we need advice.*, that is a good sign that the
feature is mis-designed".
Let me elaborate a bit on the latter.
My gut feeling is that this is absolutely the wrong place to put a
message like this. We don't know enough about what the editor is doing,
so we have to take pains to avoid a crufty message in the terminal,
- playing ANSI-term trickery to erase the message
- hard-coding (!) emacsclient as a special case
And that's why I say that "advice.*" is a bad sign, because it means
those other techniques are failing, and somebody is seeing and being
annoyed by the cruft.
The right place for this message, IMHO, is for the editor itself (or a
wrapper script) to say "hey, I'm opening a new window" (like emacsclient
But I also recognize that the world isn't perfect. Not all editors will
get this right, and not all users are savvy enough to set up a wrapper
script for editors which don't. So defaulting this to "on" tries to help
If the anti-cruft techniques I mentioned above work well in practice,
then we get to have our cake and eat it, too. If they don't, then I'm
not sure if the tradeoff is worth it.