Re: [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack
- Date: Mon, 27 Nov 2017 14:01:36 +0900
- From: Takuto Ikuta <tikuta@xxxxxxxxxx>
- Subject: Re: [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack
2017-11-27 13:53 GMT+09:00 Junio C Hamano <gitster@xxxxxxxxx>:
> Jeff King <peff@xxxxxxxx> writes:
>>> cf. https://public-inbox.org/git/20171120202920.7ppcwmzkxifywtoj@xxxxxxxxxxxxxxxxxxxxx/
>> It's funny that we'd get two patches so close together. AFAIK the
>> slowness here has been with us for years, and I just happened to
>> investigate it recently.
Yes, thank you for let me know.
Please ignore my patch, sorry.
>>> The 5-patch series that contains the same change as this one is
>>> cooking and will hopefully be in the released version before the end
>>> of the year.
>> I'd be curious if the 5th patch there provides an additional speedup for
>> Takuto's case.
> Indeed, it is a very good point.
> IIUC, the 5th one is about fetching tons of refs that you have never
> seen, right? If a repository that has trouble with everything-local
> is suffering because it right now has 300k remote-tracking branches,
> I'd imagine that these remote-tracking branches are being added at a
> considerable rate, so I'd not be surprised if these "new" refs
> benefits from that patch. And it would be nice to know how much a
> real life scenario actually does improve.
In chromium repository, your 5th patch does not improve performance,
took more than 5 minutes to run fetch on windows.
4th patch is very important for the repository in daily fetch.
I hope your 4th patch will be merged.
Software Engineer in Tokyo
Chrome Infrastructure (goma team)