Re: [PATCH] Fix NO_LIBPCRE1_JIT to fully disable JIT
- Date: Mon, 13 Nov 2017 12:53:15 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH] Fix NO_LIBPCRE1_JIT to fully disable JIT
Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:
> On Sun, Nov 12 2017, Charles Bailey jotted:
>> From: Charles Bailey <cbailey32@xxxxxxxxxxxxx>
>> If you have a pcre1 library which is compiled with JIT enabled then
>> PCRE_STUDY_JIT_COMPILE will be defined whether or not the
>> NO_LIBPCRE1_JIT configuration is set.
>> This means that we enable JIT functionality when calling pcre_study
>> even if NO_LIBPCRE1_JIT has been explicitly set and we just use plain
>> pcre_exec later.
>> Fix this by using own macro (GIT_PCRE_STUDY_JIT_COMPILE) which we set to
>> PCRE_STUDY_JIT_COMPILE only if NO_LIBPCRE1_JIT is not set and define to
>> 0 otherwise, as before.
>> I was bisecting an issue with the PCRE support that was causing a test
> [CC-ing Junio]
> Thanks a lot. This patch looks good to me.
Thanks. This patch needs a sign-off, by the way.
> But that we should take it anyway regardless of that since it'll *also*
> work on Linux with your patch, and this logic makes some sense whereas
> the other one clearly didn't and just worked by pure accident of some
> toolchain semantics that I haven't figured out yet.
That is curious and would be nice to know the answer to.