Web lists-archives.com

Re: [PATCH v3] bisect: mention "view" as an alternative to "visualize"




On Sun, 12 Nov 2017, Junio C Hamano wrote:

> "Robert P. J. Day" <rpjday@xxxxxxxxxxxxxx> writes:
>
> >  To see the currently remaining suspects in 'gitk', issue the following
> > -command during the bisection process:
> > +command during the bisection process (the subcommand `view` can, in all
> > +cases, be used as an alternative to `visualize`):
>
> I'd drop ", in all cases," if I were writing this.
>
> If it were very common that some "synonyms" are only usable in
> certain limited cases, singling this out and explicitly saying that
> "'view', unlike many other 'synonyms', is truly a synonym to
> visualize in all cases" would make sense and would help readers, but
> I do not think that is the case.  An alternative by definition
> should be usable "in all cases", so I do not think the phrase helps
> the readers at all.
>
> > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> > index fdd984d34..52f68c922 100644
> > --- a/contrib/completion/git-completion.bash
> > +++ b/contrib/completion/git-completion.bash
> > @@ -1162,7 +1162,7 @@ _git_bisect ()
> >  {
> >  	__git_has_doubledash && return
> >
> > -	local subcommands="start bad good skip reset visualize replay log run"
> > +	local subcommands="start bad good skip reset visualize view replay log run"
>
> This change makes the end user experience a lot worse, I am afraid.
>
> People used to be able to say "bisect vi<TAB>" and I'd imagine that
> many are used to type exactly that.  Now they get two choices and
> have to say 's' (or 'e') before hitting another <TAB>.

  good points, i'll re-roll and re-submit.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================