Web lists-archives.com

Re: [PATCH v2] doc/SubmittingPatches: correct subject guidance




On Wednesday 08 November 2017 at 09:10 am -0500, Eric Sunshine wrote:
> On Wed, Nov 8, 2017 at 8:47 AM, Adam Dinwoodie <adam@xxxxxxxxxxxxx> wrote:
> > +e-mail discussions.  Use of markers in addition to PATCH within
> > +the brackets to describe the nature of the patch is also
> > +encouraged.  E.g. [RFC PATCH] is often used when the patch is not
> > +ready to be applied but it is for discussion, and can be added
> > +with the `--rfc` argument to `git format-patch` or `git
> > +send-email`, while [PATCH v2], [PATCH v3] etc.  are often seen
> 
> It has become a bit of a run-on sentence, but aside from that and the
> unnecessary extra whitespace between "etc." and "are", it looks good
> to me.

Both good points, thank you!  I suspect the extra whitespace was a
result of Vim being "helpful" when reflowing the text.

I'll re-spin now with fixed whitespace and breaking up the sentence a
bit.