Re: [RFC PATCH 0/4] git-status reports relation to superproject
- Date: Wed, 8 Nov 2017 14:36:46 -0800
- From: Jonathan Tan <jonathantanmy@xxxxxxxxxx>
- Subject: Re: [RFC PATCH 0/4] git-status reports relation to superproject
On Wed, 8 Nov 2017 11:55:05 -0800
Stefan Beller <sbeller@xxxxxxxxxx> wrote:
> $ git -c status.superprojectinfo status
> HEAD detached at v2.15-rc2
> superproject is 6 commits behind HEAD 7070ce2..5e6d0fb
> nothing to commit, working tree clean
> How cool is that?
> This series side steps the questions raised in
> which I am also putting together albeit slowly.
> This series just reports the relationship between the superprojects gitlink
> (if any) to HEAD. I think that is useful information in the current
> world of submodules.
The relationship is indeed currently useful, but if the long term plan
is to strongly discourage detached submodule HEAD, then I would think
that these patches are in the wrong direction. (If the long term plan is
to end up supporting both detached and linked submodule HEAD, then these
patches are fine, of course.) So I think that the plan referenced in
Junio's email (that you linked above) still needs to be discussed.
About the patches themselves, they look OK to me. Some minor things off
the top of my head are to retain the "ours" and "theirs" (instead of
"one" and "two"), and to replicate the language in remote.c more closely
("This submodule is (ahead of/behind) the superproject by %d commit(s)")
instead of inventing your own.