Re: [PATCH] setup: avoid double slashes when looking for HEAD
- Date: Fri, 3 Nov 2017 14:38:36 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH] setup: avoid double slashes when looking for HEAD
On Fri, Nov 03, 2017 at 01:58:02PM +0100, Johannes Schindelin wrote:
> From: Jeff King <peff@xxxxxxxx>
> Andrew Baumann reported that when called outside of any Git worktree,
> `git rev-parse --is-inside-work-tree` eventually tries to access
> `//HEAD`, i.e. any `HEAD` file in the root directory, but with a double
> This double slash is not only unintentional, but is allowed by the POSIX
> standard to have a special meaning. And most notably on Windows, it
> does, where it refers to a UNC path of the form `//server/share/`.
> As a consequence, afore-mentioned `rev-parse` call not only looks for
> the wrong thing, but it also causes serious delays, as Windows will try
> to access a server called `HEAD`. Let's simply avoid the unintended
> double slash.
> Signed-off-by: Jeff King <peff@xxxxxxxx>
> Acked-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
Thanks, this explanation looks good to me (and the patch is flawless, of
course ;) ).