Re: [PATCH 00/14] WIP Partial clone part 3: clone, fetch, fetch-pack, upload-pack, and tests
- Date: Fri, 3 Nov 2017 10:22:43 -0400
- From: Jeff Hostetler <git@xxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 00/14] WIP Partial clone part 3: clone, fetch, fetch-pack, upload-pack, and tests
On 11/2/2017 7:41 PM, Jonathan Tan wrote:
On Thu, 2 Nov 2017 20:31:15 +0000
Jeff Hostetler <git@xxxxxxxxxxxxxxxxx> wrote:
From: Jeff Hostetler <jeffhost@xxxxxxxxxxxxx>
This is part 3 of 3 for partial clone.
It assumes that part 1  and part 2  are in place.
Part 3 is concerned with the commands: clone, fetch, upload-pack, fetch-pack,
remote-curl, index-pack, and the pack-protocol.
Jonathan and I independently started on this task. This is a first
pass at merging those efforts. So there are several places that need
refactoring and cleanup. In particular, the test cases should be
squashed and new tests added.
Thanks. What are your future plans with this patch set? In particular, the
tests don't pass at HEAD^.
Patch 14/14 fixed 2 existing tests. I think I want to merge that with
patch 2/14 as part of the cleanup.
Bigger picture, I would like squash all this down. But first I wanted
you to see if there was anything I missed during the merge.
I took a quick glance to see if there were any issues that I could
immediately spot, but couldn't find any. I thought of fetch_if_missing,
but it seems that it is indeed used in this patch set (as expected).
I'll look at it more thorougly, and feel free to let me know if there is
anything in particular you would like comments on.
Thanks, will do.