Web lists-archives.com

Re: [PATCH v2 14/24] refs: convert peel_ref to struct object_id




On 10/09/2017 03:11 AM, brian m. carlson wrote:
> Convert peel_ref (and its corresponding backend) to struct object_id.
> 
> This transformation was done with an update to the declaration,
> definition, and test helper and the following semantic patch:
> 
> @@
> expression E1, E2;
> @@
> - peel_ref(E1, E2.hash)
> + peel_ref(E1, &E2)
> 
> @@
> expression E1, E2;
> @@
> - peel_ref(E1, E2->hash)
> + peel_ref(E1, E2)
> 
> Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx>
> ---
>  builtin/describe.c        | 2 +-
>  builtin/pack-objects.c    | 4 ++--
>  builtin/show-ref.c        | 2 +-
>  refs.c                    | 8 ++++----
>  refs.h                    | 4 ++--
>  refs/files-backend.c      | 8 ++++----
>  refs/packed-backend.c     | 4 ++--
>  refs/refs-internal.h      | 2 +-
>  t/helper/test-ref-store.c | 6 +++---
>  upload-pack.c             | 2 +-
>  10 files changed, 21 insertions(+), 21 deletions(-)
> 
> [...]
> diff --git a/refs.h b/refs.h
> index 8159b7b067..832ade2b13 100644
> --- a/refs.h
> +++ b/refs.h
> @@ -120,8 +120,8 @@ extern int refs_init_db(struct strbuf *err);
>   * ultimately resolve to a peelable tag.
>   */

The comment just above needs to be adjusted.

>  int refs_peel_ref(struct ref_store *refs, const char *refname,
> -		  unsigned char *sha1);
> -int peel_ref(const char *refname, unsigned char *sha1);
> +		  struct object_id *oid);
> +int peel_ref(const char *refname, struct object_id *oid);
>  
>  /**
>   * Resolve refname in the nested "gitlink" repository in the specified
> [...]

Michael