Re: [RFC] column: show auto columns when pager is active
- Date: Mon, 9 Oct 2017 19:27:19 -0400
- From: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
- Subject: Re: [RFC] column: show auto columns when pager is active
On Mon, Oct 9, 2017 at 5:45 PM, Kevin Daudt <me@xxxxxxxxx> wrote:
> When columns are set to automatic for git tag and the output is
> paginated by git, the output is a single column instead of multiple
> Standard behaviour in git is to honor auto values when the pager is
> active, which happens for example with commands like git log showing
> colors when being paged.
> Since ff1e72483 (tag: change default of `pager.tag` to "on",
> 2017-08-02), the pager has been enabled by default, exposing this
> problem to more people.
> finalize_colopts in column.c only checks whether the output is a TTY to
> determine if columns should be enabled with columns set to autol. Also check
> if the pager is active.
> Helped-by: Rafael Ascensão <rafa.almas@xxxxxxxxx>
> Signed-off-by: Kevin Daudt <me@xxxxxxxxx>