Web lists-archives.com

Re: [PATCH 2/2] tests: fix diff order arguments in test_cmp




Stefan Beller wrote:

> Fix the argument order for test_cmp. When given the expected
> result first the diff shows the actual output with '+' and the
> expectation with '-', which is the convention for our tests.
>
> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx>
> ---

Yes, this should make the output from failing tests easier to take in
at a glance.

Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>

How did you find these?  E.g. is there a grep pattern that reviewers
can use to repeat your results?