Re: [PATCH 1/1] completion: Add forgotten describe options
- Date: Fri, 6 Oct 2017 19:53:41 +0200 (CEST)
- From: Thomas Braun <thomas.braun@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH 1/1] completion: Add forgotten describe options
> Stefan Beller <sbeller@xxxxxxxxxx> hat am 6. Oktober 2017 um 00:17 geschrieben:
> On Thu, Oct 5, 2017 at 2:23 PM, Thomas Braun
> <thomas.braun@xxxxxxxxxxxxxxxxxxx> wrote:
> > completion: Add forgotten describe options
> When/Why was it forgotten? git-blame thinks it was me in b0176ce6b5
> (builtin/describe: introduce --broken flag, 2017-03-21)
> Which do you add? (dirty and broken)
> I had these questions when reading the subject (which is the
> equivalent of reading the output of `git log --oneline` in the future)
> I think a better wording might be
> completion: add --broken and --dirty to describe
> When the flags for broken and dirty were implemented in
> b0176ce6b5 (builtin/describe: introduce --broken flag, 2017-03-21)
> and 9f67d2e827 (Teach "git describe" --dirty option, 2009-10-21)
> the completion was not updated, although these flags are useful
> completions. Add them.
Thanks for the review. Your commit message is (obviously) much better than mine. Reroll follows.
> > ---
> The patch looks correct.