Web lists-archives.com

Re: Enhancement request: git-push: Allow (configurable) default push-option

Hi Stefan,

I will look at it.


2017-10-03 18:53 GMT+02:00 Stefan Beller <sbeller@xxxxxxxxxx>:
> On Tue, Oct 3, 2017 at 3:15 AM, Marius Paliga <marius.paliga@xxxxxxxxx> wrote:
>> There is a need to pass predefined push-option during "git push"
>> without need to specify it explicitly.
>> In another words we need to have a new "git config" variable to
>> specify string that will be automatically passed as "--push-option"
>> when pushing to remote.
>> Something like the following:
>> git config push.optionDefault AllowMultipleCommits
>> and then command
>>   git push
>> would silently run
>>   git push --push-option "AllowMultipleCommits"
> We would need to
> * design this feature (seems like you already have a good idea what you need)
> * implement it (see builtin/push.c):
>  - move "struct string_list push_options = STRING_LIST_INIT_DUP;"
>   to be a file-static variable, such that we have access to it outside
> of cmd_push.
>  - In git_push_config in builtin/push.c that parses the config, we'd
> need to check
>   for "push.optionDefault" and add these to the push_options (I assume multiple
>   are allowed)
> * document it (Documentation/git-push.txt)
> * add a test for it ? (t/t5545-push-options.sh)
> Care to write a patch? Otherwise I'd mark it up as part of
> #leftoverbits for now,
> as it seems like a good starter project.
> Thanks,
> Stefan