Web lists-archives.com

Re: [PATCH 04/24] refs: convert update_ref and refs_update_ref to use struct object_id




On Mon, Oct 02, 2017 at 03:37:38PM -0700, Stefan Beller wrote:
> > diff --git a/bisect.c b/bisect.c
> > index 96beeb5d13..e8470a2e0f 100644
> > --- a/bisect.c
> > +++ b/bisect.c
> > @@ -685,11 +685,13 @@ static int bisect_checkout(const struct object_id *bisect_rev, int no_checkout)
> >         char bisect_rev_hex[GIT_MAX_HEXSZ + 1];
> >
> >         memcpy(bisect_rev_hex, oid_to_hex(bisect_rev), GIT_SHA1_HEXSZ + 1);
> > -       update_ref(NULL, "BISECT_EXPECTED_REV", bisect_rev->hash, NULL, 0, UPDATE_REFS_DIE_ON_ERR);
> > +       update_ref(NULL, "BISECT_EXPECTED_REV", bisect_rev, NULL, 0,
> > +                  UPDATE_REFS_DIE_ON_ERR);
> 
> The number of characters decrease, yet the line gets an additional
> line break. While I don't mind this, the most interesting question that
> comes to mind is whether you tried the new clang formatting options
> in tree to adapt the indentation? ;)

I didn't.  Sometimes I use Coccinelle to convert part of a patch and fix
up the rest by hand, and it really likes to break lines at certain
points.  I expect that I'll do at least one reroll, so I'll fix this.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204

Attachment: signature.asc
Description: PGP signature