Re: [PATCH] PR msg: capitalise "Git" to make it a proper noun
- Date: Mon, 2 Oct 2017 16:09:59 -0700
- From: Jonathan Nieder <jrnieder@xxxxxxxxx>
- Subject: Re: [PATCH] PR msg: capitalise "Git" to make it a proper noun
Thanks for working to improve Git!
> Subject: [PATCH] PR msg: capitalise "Git" to make it a proper noun
nit: What is a PR msg? Looking with "git log git-request-pull.sh",
I see that previous patches called the subsystem request-pull, so
this could be
request-pull: capitalise "Git" to make it a proper noun
> Of the many ways to spell the three-letter word, the variant "Git"
> should be used when referring to a repository in a description; or, in
> general, when it is used as a proper noun.
> We thus change the pull-request template message so that it reads
> "...in the Git repository at:"
> Besides, this brings us in line with the documentation, see
> Signed-off-by: bedhanger <bedhanger@xxxxxx>
Please use your full name in the Signed-off-by line. See
Documentation/SubmittingPatches section "(5) Certify your work" for
why we ask for this.
> git-request-pull.sh | 2 +-
> t/t5150-request-pull.sh | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
The patch itself looks good, and I like the change it makes to the
email generated by git request-pull. Looking forward to seeing what
other changes you come up with in the future.
Thanks and hope that helps,