Re: [PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers
- Date: Mon, 2 Oct 2017 15:42:08 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH v2] ref-filter.c: pass empty-string as NULL to atom parsers
On Mon, Oct 02, 2017 at 09:10:34AM -0700, Taylor Blau wrote:
> Peff points out that different atom parsers handle the empty
> "sub-argument" list differently. An example of this is the format
> Since callers often use `string_list_split` (which splits the empty
> string with any delimiter as a 1-ary string_list containing the empty
> string), this makes handling empty sub-argument strings non-ergonomic.
> Let's fix this by assuming that atom parser implementations don't care
> about distinguishing between the empty string "%(refname:)" and no
> sub-arguments "%(refname)".
> Signed-off-by: Taylor Blau <me@xxxxxxxxxxxx>
> ref-filter.c | 10 +++++++++-
> t/t6300-for-each-ref.sh | 1 +
> 2 files changed, 10 insertions(+), 1 deletion(-)
This looks good to me, thanks.