Re: [PATCH] builtin/: add UNLEAKs
- Date: Mon, 02 Oct 2017 13:07:26 +0900
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH] builtin/: add UNLEAKs
Martin Ågren <martin.agren@xxxxxxxxx> writes:
> ... While addressing `msg` in builtin/tag.c, convert the existing
> `strbuf_release()` calls as well.
That part of this patch made me raise eyebrows a bit but only
slightly. We are about to leave the function to exit anyway, and
all the other that got new UNLEAK(var) at the end are doing the same
So overall I think this patch makes sense. Thanks.