[PATCH] commit-tree: don't append a newline with -F
- Date: Thu, 7 Sep 2017 10:41:11 -0400
- From: Ross Kabus <rkabus@xxxxxxxxxxxx>
- Subject: [PATCH] commit-tree: don't append a newline with -F
This change makes it such that commit-tree -F never appends a newline
character to the supplied commit message (either from file or stdin).
Previously, commit-tree -F would always append a newline character to
the text brought in from file or stdin. This has caused confusion in a
number of ways:
- This is a plumbing command and it is generally expected not to do
text cleanup or other niceties.
- stdin piping with "-F -" appends a newline but stdin piping without
-F does not append a newline (inconsistent).
- git-commit does not specifically append a newline to the "-F"
input. The issue is somewhat muddled by the fact that git-commit
does pass the message through its --cleanup option, which may add
such a newline. But for commit-tree to match "commit --cleanup=verbatim",
we should not do so here.
Signed-off-by: Ross Kabus <rkabus@xxxxxxxxxxxx>
builtin/commit-tree.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/commit-tree.c b/builtin/commit-tree.c
index 19e898fa4..2177251e2 100644
@@ -102,7 +102,6 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)
if (fd && close(fd))
die_errno("git commit-tree: failed to close '%s'",