Re: [PATCH 1/2] system_path: move RUNTIME_PREFIX to a sub-function
- Date: Wed, 6 Sep 2017 09:27:57 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 1/2] system_path: move RUNTIME_PREFIX to a sub-function
On Wed, Sep 06, 2017 at 03:23:42PM +0200, Johannes Schindelin wrote:
> On Wed, 6 Sep 2017, Jeff King wrote:
> > I find the diff hard to read because it shows the opposite of what I did
> > (moving the big block to its own function, rather than moving the little
> > bits to a new copy of the function).
> I guess --patience would have made it slightly more readable. I did not
> find any commit in your fork on GitHub with the commit subject, else I
> would have pasted the output of `git diff --patience` here.
I hadn't pushed it yet (but it's there now, 130217f4a). Neither
--patience nor --histogram produces markedly different results. I think
the issue is just that what I actually did (moving the big inner block)
is not nearly as minimal a diff as moving what surrounds it.