Re: [Bug] commit-tree shouldn't append an extra newline to commit messages
- Date: Tue, 5 Sep 2017 11:09:01 -0400
- From: Ross Kabus <rkabus@xxxxxxxxxxxx>
- Subject: Re: [Bug] commit-tree shouldn't append an extra newline to commit messages
On Sat, Sep 2, 2017 at 4:33 AM, Jeff King <peff@xxxxxxxx> wrote:
> But I am confused by your "inconsistent with git commit porcelain"
> comment. The porcelain git-commit definitely _does_ add a newline if one
> isn't present (and in fact runs the whole thing through git-stripspace
> to clean up whitespace oddities).
Ok I figured out my confusion. The repository I am working with did
commits with "git commit --cleanup=verbatim" thus do not have a newline.
This is why I thought there was an inconsistency.
> So I don't think "inconsistent with git-commit" is a compelling
> argument, unless I'm missing something.
Agreed, but now I guess I would argue that it is inconsistent because
it lacks a "verbatim" option like git-commit has. I would like to see
an argument like this for commit-tree but a clean way to add this option
didn't immediately jump out at me.
> And definitely it does not when taking the message in via stdin.
I'm not seeing this, I see commit-tree as adding a new line even via
stdin (and the code seems to corroborate this), unless I missed something.