Web lists-archives.com

Re: [PATCH 08/34] connect: release strbuf on error return in git_connect()




>         } else {
> +               struct strbuf cmd = STRBUF_INIT;
> +
...
>                 strbuf_addstr(&cmd, prog);
>                 strbuf_addch(&cmd, ' ');
>                 sq_quote_buf(&cmd, path);

...
>                 if (start_command(conn))
>                         die("unable to fork");
...
>                 strbuf_release(&cmd);

Here I reread the cover letter, your intent is only to fix memleaks
on non-die code paths. Ok. (unlike the grand vision of an
"always valgrind clean program")

Thanks,
Stefan