Re: [PATCH 0/4] dropping support for older curl
- Date: Thu, 10 Aug 2017 15:17:06 -0700
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH 0/4] dropping support for older curl
Jeff King <peff@xxxxxxxx> writes:
> On Thu, Aug 10, 2017 at 11:36:41AM +0200, Johannes Schindelin wrote:
>> Hopefully I had better luck expressing my concerns this time?
> I understand your argument much better now. I'm still not sure I agree.
I do not think "there are a dozen #ifdefs and I don't know whether
they still work. I don't know whether anybody (who most likely has
better things to do than read the Git mailing list) is still using
those. So let's just remove them." was why you were suggesting to
clean up the (apparent) support of older curl in the code, though.
Isn't the reason why your series simplifies these #ifdefs away
because we by accident started using some features that require a
version that is even newer than any of these #ifdef's try to cater
to and yet nobody complained? That is a lot more similar to the
removal of rsync transport that happened in a not so distant past,
where the reason for removal was "We have been shipping code that
couldn't have possibly worked for some time and nobody complained
---we know nobody is depending on it."
Or "We accidentally started shipping code with comma after the last
element of enum decl and nobody compalined---everybody's compiler
must be ready" ;-)