Re: [PATCH 2/4] http: drop support for curl < 7.16.0
- Date: Wed, 9 Aug 2017 17:15:21 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 2/4] http: drop support for curl < 7.16.0
On Wed, Aug 09, 2017 at 10:40:13AM -0700, Junio C Hamano wrote:
> Jeff King <peff@xxxxxxxx> writes:
> > -#if LIBCURL_VERSION_NUM >= 0x071700
> > -/* Use CURLOPT_KEYPASSWD as is */
> > -#elif LIBCURL_VERSION_NUM >= 0x070903
> > -#define CURLOPT_KEYPASSWD CURLOPT_SSLKEYPASSWD
> > -#else
> > -#define CURLOPT_KEYPASSWD CURLOPT_SSLCERTPASSWD
> > -#endif
> > -
> This part I am not sure. Don't we still need to substitute
> CURLOPT_KEYPASSWD with CURLOPT_SSLKEYPASSWD for versions below
> 071700, e.g. 071000 which is 7.16.0?
Yeah, you're right. I'm not sure how I botched that.
Thanks for reading carefully. I'll fix it in a re-roll.