Re: [PATCH 1/2] sha1_file: drop experimental GIT_USE_LOOKUP search
- Date: Wed, 9 Aug 2017 17:09:47 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 1/2] sha1_file: drop experimental GIT_USE_LOOKUP search
On Wed, Aug 09, 2017 at 11:12:19AM -0700, Junio C Hamano wrote:
> Thanks for reducing the count of binary search functions by one.
> I think the "just one round of newton-raphson" in sha1_pos() comes
> from [*1*]; I agree that it needs benchmarking before tweaking it.
Actually, it's weirder than that. You mentioned it in that thread, but
the code dates back much further. It was moved to the file in 96beef8,
but that was just a copy from patch-ids.c. The original seems to be from
5d23e133d2 (Refactor patch-id filtering out of git-cherry and
git-format-patch., 2007-04-09), which predates the sha1_entry_pos()
I always thought those two sha1-lookup functions came in the opposite
order, but I guess was wrong. Or possibly you are a time traveler.
> We may want to tell libgit2 folks about this change, though [*2*].
> I think they too are carrying dead code that is only used under CPP
> macro GIT_USE_LOOKUP, which they do not seem to define.
Good thinking. It looks like they could use all three of the patches
under discussion. I opened some PRs: