Web lists-archives.com

Re: [PATCH 5/5] interpret-trailers: add --parse convenience option




On Wed, Aug 9, 2017 at 5:26 AM, Jeff King <peff@xxxxxxxx> wrote:
> The last few commits have added command line options that
> can turn interpret-trailers into a parsing tool. Since
> they'd most often be used together, let's provide a
> convenient single option for callers to invoke this mode.
>
> This is implemented as a callback rather than a boolean so
> that its effect is applied immediately, as if those options
> had been specified. Later options can then override them.
> E.g.:
>
>   git interpret-trailers --parse --no-normalize
>
> would work.
>
> Signed-off-by: Jeff King <peff@xxxxxxxx>
> ---
>  Documentation/git-interpret-trailers.txt |  4 ++++
>  builtin/interpret-trailers.c             | 12 ++++++++++++
>  2 files changed, 16 insertions(+)
>
> diff --git a/Documentation/git-interpret-trailers.txt b/Documentation/git-interpret-trailers.txt
> index 6d867e8ab3..ab2d5c7696 100644
> --- a/Documentation/git-interpret-trailers.txt
> +++ b/Documentation/git-interpret-trailers.txt
> @@ -93,6 +93,10 @@ OPTIONS
>         line, with any existing whitespace continuation folded into a
>         single line.
>
> +--parse::
> +       A convenience alias for `--only-trailers --only-existing
> +       --normalize`.

Somewhere in this series, we'd want to not just describe each
of the new knobs, but reword the initial description, too?

    git-interpret-trailers - help add structured information
        into commit messages

Maybe a s/add/handle/ s/into// is enough?