Re: [PATCH] test-path-utils: handle const parameter of basename and dirname
- Date: Mon, 7 Aug 2017 23:15:01 +0200 (CEST)
- From: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
- Subject: Re: [PATCH] test-path-utils: handle const parameter of basename and dirname
On Mon, 7 Aug 2017, René Scharfe wrote:
> The parameter to basename(3) and dirname(3) traditionally had the type
> "char *", but on OpenBSD it's been "const char *" for years. That
> causes (at least) Clang to throw an incompatible-pointer-types warning
> for test-path-utils, where we try to pass around pointers to these
> Avoid this warning (which is fatal in DEVELOPER mode) by ignoring the
> promise of OpenBSD's implementations to keep input strings unmodified
> and enclosing them in POSIX-compatible wrappers.
> Signed-off-by: Rene Scharfe <l.s.r@xxxxxx>
This patch is Fine By Me.