Re: [PATCH 3/4] imap_send: setup_curl: use server_conf parameter instead of the global variable
- Date: Mon, 7 Aug 2017 15:50:03 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 3/4] imap_send: setup_curl: use server_conf parameter instead of the global variable
On Mon, Aug 07, 2017 at 07:06:07PM +0200, Nicolas Morey-Chaisemartin wrote:
> >> - server_fill_credential(&server);
> >> - curl_easy_setopt(curl, CURLOPT_USERNAME, server.user);
> >> - curl_easy_setopt(curl, CURLOPT_PASSWORD, server.pass);
> >> + server_fill_credential(srvc);
> >> + curl_easy_setopt(curl, CURLOPT_USERNAME, srvc->user);
> >> + curl_easy_setopt(curl, CURLOPT_PASSWORD, srvc->pass);
> > Here you change the server_fill_credential-call that you just added.
> > Maybe do this patch earlier, perhaps even as patch 1?
> > I'm snipping lots of s/server/srvc/-changes... There's a less noisy
> > way of addressing the fact that srvc is unused: dropping it. I'm not
> > saying that's a good idea, but it could be considered, then explained
> > why this approach is better. There are some other functions which
> > access "server" directly, and some which take (and use!) a "srvc".
> > Maybe make the whole file consistent?
> That's why I applied it after #2. I was not sure if this one made
> sense or not. And it can be dropped with the rest of the series still
> I don't know what is the right approach here. Someone with more
> knowledge of why there is a mix of global variable and local can maybe
> help ?
I suspect it's just code in need of a cleanup. But let's cc the original
author of 1e16b255b (git-imap-send: use libcurl for implementation,
2014-11-09) to see if he has any comments.
 Bernhard, the whole series is at:
The general idea is to make sure the original and curl imap-send
implementations have feature parity, make the curl version the
default, and then hopefully eventually drop the non-curl one