Re: [PATCH 2/4] revision: add rev_input_given flag
- Date: Wed, 2 Aug 2017 19:11:15 -0400
- From: Jeff King <peff@xxxxxxxx>
- Subject: Re: [PATCH 2/4] revision: add rev_input_given flag
On Wed, Aug 02, 2017 at 03:41:52PM -0700, Junio C Hamano wrote:
> Jeff King <peff@xxxxxxxx> writes:
> > Normally a caller that invokes setup_revisions() has to
> > check rev.pending to see if anything was actually queued for
> > the traversal. But they can't tell the difference between
> > two cases:
> > 1. The user gave us no tip from which to start a
> > traversal.
> > 2. The user tried to give us tips via --glob, --all, etc,
> > but their patterns ended up being empty.
> > Let's set a flag in the rev_info struct that callers can use
> > to tell the difference. We can set this from the
> > init_all_refs_cb() function. That's a little funny because
> > it's not exactly about initializing the "cb" struct itself.
> > But that function is the common setup place for doing
> > pattern traversals that is used by --glob, --all, etc.
> ...and "--bisect", which is an oddball so we probably do not have to
> care. I didn't check if there is a fallout on that codepath.
Yeah, I saw that one and figured it should probably as "input given".
There's also "--reflog" and "--indexed-objects", which aren't covered
here. I'm not sure if anybody really cares (you'd generally use them
with "--all" anyway), so I left them out for now.