Web lists-archives.com

Re: [PATCH v6 02/10] rebase -i: generate the script via rebase--helper




Hi Stefan,

On Fri, 14 Jul 2017, Stefan Beller wrote:

> There are two conflicting messages I get:
> * only a few fields seem to be polluted (verbose_header,
>   max_parents), much fewer than I thought
> * we do use these undocumented ways already,
>   but not at the scale that DScho is trying to here.

We use mostly undocumented ways, because there is simply no API. It was
decided early on that libgit was never intended to be a public API. So
that's that.

TBH a much better way to handle this would have been to say: this is
fragile, as the pretty-printing is not properly abstracted, and hence we
may need to break the contract at some stage (which would not cause
compile errors, though), maybe you, Dscho, can fix that after this patch
series was applied by abstracting it properly?

Ciao,
Dscho