Re: [PATCH v2 0/3] interpret-trailers: add --where, --if-exists, --if-missing
- Date: Wed, 12 Jul 2017 16:02:29 -0700
- From: Junio C Hamano <gitster@xxxxxxxxx>
- Subject: Re: [PATCH v2 0/3] interpret-trailers: add --where, --if-exists, --if-missing
Paolo Bonzini <bonzini@xxxxxxx> writes:
> From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> These options are useful to experiment with "git interpret-trailers"
> without having to tinker with .gitconfig. It can also be useful in the
> oddball case where you want a different placement for the trailer.
> Compared to "git -c", they are more easily discoverable, and also have
> slightly different behavior because they override all trailer.*
> configuration keys.
I think this is a very good idea (we shouldn't have started the
command only with the configurations; we rather should have done
this first and then added configuration after that).
Looking forward to reviewing them, but I am cutting a maint release
now, so it may have to wait a bit.
> v1->v2: support --no-* options, minor code fixes
> Paolo Bonzini (3):
> trailers: create struct trailer_opts
> trailers: export action enums and corresponding lookup functions
> interpret-trailers: add options for actions
> Documentation/git-interpret-trailers.txt | 16 +++++
> builtin/interpret-trailers.c | 44 ++++++++++---
> t/t7513-interpret-trailers.sh | 66 ++++++++++++++++++++
> trailer.c | 102 ++++++++++++++++++++-----------
> trailer.h | 35 ++++++++++-
> 5 files changed, 218 insertions(+), 45 deletions(-)