Re: [PATCH 1/3] repo_read_index: don't discard the index
- Date: Wed, 12 Jul 2017 10:27:44 -0700
- From: Brandon Williams <bmwill@xxxxxxxxxx>
- Subject: Re: [PATCH 1/3] repo_read_index: don't discard the index
On 07/11, Jonathan Nieder wrote:
> Brandon Williams wrote:
> > Have 'repo_read_index()' behave more like the other read_index family of
> > functions and don't discard the index if it has already been populated.
> > Signed-off-by: Brandon Williams <bmwill@xxxxxxxxxx>
> > ---
> > repository.c | 2 --
> > 1 file changed, 2 deletions(-)
> How did you discover this? E.g. was it from code inspection or does
> this make the function more convenient to use for some kinds of callers?
When working on another series I realized that some code paths may end
up calling read_index() a bunch and I want to prevent discarding and
then re-reading the same index over and over again if/when those calls
are migrated to using repo_read_index.
> Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>