Web lists-archives.com

Re: [PATCH 3/7] git.c: provide setup_auto_pager()




On 11 July 2017 at 12:37, Jeff King <peff@xxxxxxxx> wrote:
> On Mon, Jul 10, 2017 at 11:55:16PM +0200, Martin Ågren wrote:
>
>> +void setup_auto_pager(const char *cmd, int def)
>> +{
>> +     if (use_pager != -1)
>> +             return;
>
> I think you probably also want to return early here if pager_in_use()
> is true. If a script runs "git tag -l", you wouldn't want to start a new
> pager when the outer script has already been paged (either via config,
> or via "git -p").

Good point. Thanks.

Martin